Jean-Paul Calderone

The Action fails with "Could not setup Developer Command Prompt"

11

Attempting to use the action like this: ``` name: Python package on: [push] jobs: build: runs-on: "windows-latest" strategy: matrix: python-version: - "2.7" steps: - uses: ilammy/msvc-dev-cmd@v1 ``` results in a...

Tracebacks going through `eliot.twisted.inline_callbacks` lose some important frames at the end

8

Consider: ``` from eliot.twisted import inline_callbacks from twisted.internet.defer import fail @inline_callbacks def foo(): yield yield bar() @inline_callbacks def bar(): yield raise Exception("Some problem") foo() ``` This results in the following...

Intermittent failure from test_omitLoggerFromActionType in 1.7.0

6

Seen on my CI: ``` FAIL: test_omitLoggerFromActionType (eliot.tests.test_validation.EndToEndValidationTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/tmp/nix-build-python2.7-eliot-1.7.0.drv-0/eliot-1.7.0/eliot/tests/test_validation.py", line 895, in test_omitLoggerFromActionType self.assertEqual(messages[0]["key"], 123) AssertionError: 5 != 123 ``` This is a...

log_call could be more useful if it interoperated with the type system

6

`log_call` is appealing for the effort/lines it saves. But using it requires giving up on the Field system. If I have an ActionType `FOO` defined, it would be nice to...

Add an API for binding a callable to an action context

1

This idea is similar to the idea behind DeferredContext. DeferredContext.addCallback takes a callable and binds it to the active action context. This is great because it gives you a way...

https://github.com/ClusterHQ/eliot/blob/master/docs/source/types.rst#message-types says `USERNAME = Field.for_types("username", [str])` (and gives several other examples of `Field.for_types` with two arguments). The method requires a third argument, the field description, so the examples don't work...

A logging test recently failed like this: ``` [ERROR] Traceback (most recent call last): File "/srv/buildslave/flocker-centos-7/venv/lib/python2.7/site-packages/twisted/trial/_synctest.py", line 1368, in _runCleanups f(*args, **kwargs) File "/srv/buildslave/flocker-centos-7/venv/lib/python2.7/site-packages/eliot/_output.py", line 257, in validate serializer.validate(dictionary) File...

Add a helper for running a Deferred-returning function in the context of an Action

1

This pattern may end up being somewhat common: ``` with an_action.context(): context = DeferredContext(some_function(args)) context.addActionFinish() return context.result ``` It would probably make sense to have a helper function for this...

This is like #153 but for the case where the test uses Twisted, returns a Deferred, and the Deferred fires with SkipTest: ``` from eliot.testing import assertHasAction, validate_logging from eliot...

It shows how to use `assertContainsFields` instead of showing how to use `validateLogging`.