Ngoc-Cuong Nguyen

Thanks for suggesting the idea of using Gmsh physical groups to define domains and boundaries.

It is not. It is the same as 2D Poisson. We'll remove it.

Hi @akohlmey, Drew and I made many changes for our package to meet LAMMPS's style requirements. We think this is ready for review but have some questions/concerns: - For collating...

> I would suggest to add a test in the code that prints a warning (with error->warning()) on MPI rank 0, if there are more than, say, 1000 atoms in...

Sorry I accidentally closed the pull request.

> > @exapde @rohskopf I have a little extra time this week. So I could help implementing some of the suggested changes. > > I have submitted a pull request...

> Yes, there are more changes needed to address issues I've come across. I've added a unit test for the pair style and noticed some memory leaks, uninitialized data accesses,...

> In the process I noticed that the pair style does not support per-atom energies and per-atom stress. There should be some code added that will print a warning. I...

> There also are some more build system and general LAMMPS "maintenance" changes needed. All of those are easier for me to just do them than to explain how to...

> @exapde @rohskopf I think that after the changes from [cesmix-mit#2](https://github.com/cesmix-mit/lammps/pull/2) are merged, this PR is ready for a general review by the other LAMMPS developers. There are still several...