Emily Williams
Emily Williams
I was hoping that the linter would allow one line conditionals. Going to append this here as a comment for now instead of making a new issue.
Bc of the time component baked into V3 math with fees, it's very difficult to make 1155's fungible per range :((( 1155's may still be worth exploration. Next PositionManager Implementation...
So I like this, and the gas savings, and I want to get this merged lol instead of leave it hanging. Even though this change allows third party lockers to...
should include invariant testing for the solvency of pools
fwiw I think the team is pretty split on this, without anyone being a diehard must-have, but we have some pretty strong no's. cons seem to outweigh the pros.
are gas savings the only reason for this PR? bc I imagine we'll inevitably go through the router anyway since we tend to aggregate across versions, so I imagine this...
fyi, if we go with the second PR referenced here, we'll definitely get your commit included in there, so you'll get credited
closing in favor of of https://github.com/Uniswap/v4-core/pull/299 just to clean things up. we are exploring no-op but taking it a step further and iterating internally. if we decide to incorporate no-op,...
Your LP position is likely through our periphery contracts (i.e. https://github.com/Uniswap/v3-periphery/blob/main/contracts/NonfungiblePositionManager.sol). Otherwise if interacting directly with the pool your ERC20 balances sit directly in the PoolManager (and must be sent...
https://github.com/Uniswap/universal-router/pull/181