Ed Wildgoose

Results 12 comments of Ed Wildgoose

I think the issue is that the .html.eex syntax needs to be implemented as an "embedded language" rather than as it is? This way it's treated as an HTML file,...

Answer is "I think so". It's quite widely discussed in the issues which lead to the introduction of this field, also it's mentioned specifically in the documentation (see :conflict_target here:...

> @ewildgoose [elixir-sqlite/ecto_sqlite3#59](https://github.com/elixir-sqlite/ecto_sqlite3/pull/59) that PR is a fix for this ya? Actually, that's the PR which reveals the problem... Prior to that I couldn't send ON CONFLICT with an :unsafe_fragment...

Hi, I think I'm explaining myself badly. I generate a bunch of SQL "by hand". This SQL functions when run directly in the sqlite cli. However, near identical SQL returns...

I've hit a similar problem, in my case I observe that we have add_class / remove_class, but I really want a "JS.toggle_class()". This seems like a simpler concern and inline...

OK, so this looks like I've introduced some bug, probably syncing with (what I'll call upstream) Error is: :erlang.iolist_to_binary([[], ["UPDATE ", [[34, "users", 34]], " AS ", [117 | "0"],...

Hi, see comment above. Main link is this: https://github.com/elixir-ecto/ecto_sql/blob/master/lib/ecto/adapters/postgres/connection.ex#L176 I had to merge it because of the extra clause we have forbidding using named contraints. I also added the error...

I presume it's this change causing the issue (or the update_fields() change, but can't see how that causes it?) ``` - [ - cte, - prefix, - fields, - join,...

That's super news! Do whatever you think is best! Happy to cooperate with what you need!