Evan Martin

Builtin msvcrt.dll/ucrtbase.dll do not export variables, making _adjust_fdiv invalid

1

msvcrt.dll exports a `_adjust_fdiv` symbol which points at a plain int. retrowin32 currently doesn't support anything other than function exports from its builtin dlls, so any program (including win2k `sol.exe`)...

As part of an upcoming change I'll generate win32 DLL files. Currently they are assembly and compiled via clang, but it might be nice to write them in Rust. That...

Set flags in imul

1

There are 4 TODOs here in imul, that we need to set flags: https://github.com/evmar/retrowin32/blob/b998e571ba9e31b4cc95e18f091376cb8372a9fb/x86/src/ops/math.rs#L787-L814 https://www.felixcloutier.com/x86/imul says: > The CF and OF flags are set when the signed integer value of...

Many unsafe memory operations

1

This project does a lot of pointer-fiddling casts and dereferences that may violate memory safety. In many cases I am still figuring out the right interface to model memory etc.,...

Fails to find source file when cross-compiling due to mixed slashes

6

From a Mac, cross-compiling to Windows: ``` $ cargo-asm -vvv -p x86 --target i586-pc-windows-msvc --rust mov_r8_rm8 [...] Artifact files: ["/Users/evmar/win/rs/target/i586-pc-windows-msvc/release/libx86.rlib", "/Users/evmar/win/rs/target/i586-pc-windows-msvc/release/deps/libx86-4448cbf56d50bb97.rmeta"] Working with file: /Users/evmar/win/rs/target/i586-pc-windows-msvc/release/deps/x86-4448cbf56d50bb97.s goal: Function { function: "mov_r8_rm8",...

Recommend file-by-file mode for Jujutsu config

2

The previous docs gave difft two directories to diff. But that loses information about file renames, which is information jj has. This configuration tells Jujutsu to pass individual pairs of...

NamedNodeMap is indexable by string

1

According to the spec (https://dom.spec.whatwg.org/#interface-namednodemap) and experimentally in Chrome, you can index a NamedNodeMap with a string and get back an Attr. The TS definition only has: ```ts interface NamedNodeMap...