rspec_rails_4
rspec_rails_4 copied to clipboard
everydayrails
Everyday Rails Testing with RSpec (Rails 4.0 Edition)
There's a slight code style inconsistency between the `GET #edit` and other specs on page 69. Specifically, the _#edit_ spec uses an intermediary variable to store the created contact while...
On page 62 the `to_csv` method takes an argument: ``` ruby format.csv do send_data Contact.to_csv(@contacts), type: 'text/csv; charset=iso-8859-1; header=present', disposition: 'attachment; filename=contacts.csv' end ``` but on page 63 it doesn't:...
This is more a question than an actual issue (and related to one of my other issues with creating contacts, see https://github.com/everydayrails/rspec_rails_4/issues/38). Does the `deletes the contact` test on page...
The spec on page 59 is different from the one originally outlined on page 50. For example the one on page 50 has a test `redirects to users#index` but the...
The spec on page 57 is completely different from the one originally outlined on page 50. For example the one on page 50 has a test `updates the contact in...
The _redirects to contacts#show" test on page 55 has a subtle bug: ``` ruby it "redirects to contacts#show" do post :create, contact: attributes_for(:contact, phones_attributes: @phones) expect(response).to redirect_to contact_path(assigns[:contact]) end ```...
This is more a question than an actual issue. In the spec on page 55, does the _saves the new contact in the database_ test really test that **the** new...
This is more a question than an actual issue. Regarding the spec on page 53, what about the requirement that contacts should be returned in sorted (ascending) order according to...
In the test _populates an array of contacts starting with the letter_ on page 53, the _Jones_ contact is assigned to an unused `jones` variable: ``` ruby it "populates an...
The _PUT #update_ spec on page 50 has a minor inconsistency in naming: ``` ruby describe 'PUT #update' do context "with valid attributes" do it "updates the contact in the...
Metadata
Owner
Metadata
Everyday Rails Testing with RSpec (Rails 4.0 Edition)