Evert Rol

Results 27 comments of Evert Rol

Great, thanks. I'm happy to live with the work-around while waiting for a proper refactoring. I guess this issue can serve as a pointer for people that run into the...

Notes and further food for thought: - I've put this here as a suggestion. The change may not be deemed necessary. - As the last sentence states, this may break...

I've just been trying, and it looks like I can confirm this is still an issue. If not the buffer size, then indeed the slice computation size: ``` ValueError: cannot...

Actually, this appears to be the case for the NetCDF and HDF5 handlers as well: I can't install these from PyPI with `pip3`, since these packages are not Python 3...

I understand the concern, and I agree that ~60 changed files with 3/5(*) lines feels a bit much (there are a large amount of classes in Gammapy though!). Then again,...

I am a bit wary of adding a utility function, because it takes the logic flow away from the class (and then back again to it): it would become `_repr_html_()`...

Whoops, that was dumb: making a change, but not checking/using it myself. Thanks @adonath, for checking. Unfortunately, the (most logical) fix requires surrounding the string version with `` and ``,...

Is this still an issue? The grpcio has long been solved, since version 1.39 at least (following the second link above; that issue has been closed there). Changing the version...

Apologies, it seems that I stupidly overlooked the license file. But I'll leave this issue open if you feel it requires an update. And I'll get work on the PR...

Related, but perhaps worth a new issue: what about contributing? There is a Contribution section in the README that covers it, so looks like no CONTRIBUTING file needed. But what...