Evan Bauer
Evan Bauer
Ok, looks like we have a compilation failure. Feel free to push a commit that fixes it and we can run the compilation test again.
Great! Looks good to me. We'll just wait for whenever Pablo (@orlox) has a chance to look at it, and we can merge it once he approves.
From Anne on slack: [convcorecpm.pdf](https://github.com/MESAHub/mesa/files/9047868/convcorecpm.pdf)
Some notes that hopefully help clarify what's going on. - Setting `conv_premix_fix_pgas = .false.` in 12778 breaks convective premixing. This means that the EOS updates internal to CPM need to...
I've started digging into this, and it looks like this issue has been around for quite a while. It also appears to affect a pretty wide range of initial masses....
Bisecting along `main` points to 1550ee1 as the change that broke things for making massive C/O WDs. It still works for making standard 0.6 solar mass WDs, but anything around...
Yeah, I hoped bisecting might point to something more useful like an EOS change, but no luck. At least we've now established that this has been a problem for several...
Maybe at the top of this block we should add something like ``` if(s% doing_relax) then s% phase_of_evolution = -1 else if ... ``` to indicate that we're in a...
Ok, I added `phase_relax = -1` in 91047bc.
Cool! Any chance you know how many terms are needed for accuracy to roughly floating point precision?