mesa icon indicating copy to clipboard operation
mesa copied to clipboard

Published 20 hours ago • verified publisher icon MESAHub

Change in check_jdot_mb_conditions and binary_controls

Open jaiken17 opened this issue 3 years ago • 4 comments

qrad_core and jdot_mb_max_qrad_core are misleading variable names since check_jdot_mb_conditions (binary/private/binary_jdot.f90) is actually checking that the convective core is not too large (ie that there actually is a radiative core). The documentation is also updated to reflect what the check_jdot_mb_conditions subroutine is actually doing.

jaiken17 avatar Aug 12 '22 05:08 jaiken17

Ok, looks like we have a compilation failure. Feel free to push a commit that fixes it and we can run the compilation test again.

evbauer avatar Aug 12 '22 22:08 evbauer

I will try to fix the compilation error later today.

jaiken17 avatar Aug 12 '22 22:08 jaiken17

I have now fixed the compilation error, and can confirm it compiles on my machine and runs one of the binary tests. I have not run the full binary test suite since I am not set up to do so at the moment.

jaiken17 avatar Aug 13 '22 04:08 jaiken17

Great! Looks good to me. We'll just wait for whenever Pablo (@orlox) has a chance to look at it, and we can merge it once he approves.

evbauer avatar Aug 13 '22 19:08 evbauer

@orlox any chance you could have a look at this? It seems @evbauer happy so can we just merge it?

rjfarmer avatar Sep 20 '22 09:09 rjfarmer