Evan Willhite

Results 28 issues of Evan Willhite

We are running into an error with the latest release that is occurring with situations containing some/all of the following characteristics: 1. Nested includes 2. Using a namespace 3. Inside...

type - bug / bugfix
pending - needs information
triaged

## [115: Add ESlint for JS](https://github.com/fourkitchens/emulsify/issues/115) _This PR changed from addressing merely ESLint to moving to ES6 syntax support for all default code._ ### Companion PR in Emulsify Gulp https://github.com/fourkitchens/emulsify-gulp/pull/108....

Status: Passes code review
Priority: Medium
Status: Review Needed

**Problem description:** Based on multiple project experiences, it seems like we should maybe look into making the wrapper/padding mixins more robust. Also, possibly decide on a specific approach for wrapper...

Priority: Low
Type: Enhancement

Looks like the menu link itself is a non-Twig template straggler leftover from D7 days of yore. This means, that when we do [this](https://github.com/fourkitchens/emulsify/blob/develop/components/_patterns/02-molecules/menus/_menu-item.twig#L27-L32) instead of using `{{ link(item.title, item.uri)...

Type: Bug
Priority: Medium
Status: Review Needed

Moving from Emulsify Gulp as this affects the package.json file here. Also, bumping this up in priority as build tools are not liking it either. Original issue comment from @infiniteluke:...

Status: In Progress
Type: Feature
Priority: Medium

We've done some work here, but we could stand to do a little more. Here's the [reference](https://www.24a11y.com/2018/accessible-svg-icons-with-inline-sprites/?utm_source=CSS-Weekly&utm_campaign=Issue-343&utm_medium=email).

Priority: Medium
Status: Review Needed

The [trans tag](https://github.com/fourkitchens/emulsify/blob/develop/components/_twig-components/tags/pl_trans.tag.php) appears to be a copy of the Drupal trans tag instead of being something that just is a pass-through in Pattern Lab (doesn't need to actually translate...

Priority: Low
Type: Enhancement

Research using https://prettier.io/ for autoformatting code not in place of, but alongside ESLint and Stylelint. Would like to configure both linters to ignore things Prettier will automatically fix. Marking as...

Status: On Hold
Type: Feature

`Drupal.behaviors` is still the recommended approach for writing JavaScript in Drupal. We would rather commit to writing ES6 JavaScript following best practice conventions (regardless of system), so we discussed separating...

Type: Feature
Priority: Low

Compile all useful components into Emulsify core, and provide config via companion modules. e.g. * Hero component styles come with Emulsify core * `emulsify_heroes` module includes config to create the...

Type: Feature
Priority: Low