Evan Jones

Results 55 comments of Evan Jones

I need it to apply to *all* metrics that come in, without modifying the applications. Correct me if I'm wrong, but I don't see a way to do that. The...

Thanks for the note! That definitely seems relevant. I'll watch the commit log. Thanks!

Yes this is great; we will attempt to look into implementing this ourselves. I started and it seems like it will be pretty trivial, but we need to test/finish it....

This will unfortunately conflict with #61 . If you merge one of them, I'll happily fix the merge/rebase conflicts on the other for you. Thanks!

This is great! I actually cooked up a similar hack that I called "pythonpath" for our own Python monorepo. I'd be happy to post my change for comparison, but this...

Turns out this is currently impossible due to https://github.com/bazelbuild/bazel/issues/2617 ; Bazel does not expose the `imports` attribute. As a result, it is impossible to write Skylark rules to do this.

In the meantime, since this still hasn't landed, I've implemented a `pythonroot` attribute that lets me say "subdirectory `//other_python_root`" is a "root" of the Python import tree. I then rewrite...

Yes, it is very similar, although my version adds a `pythonroot` attribute to `pex_library` to be able to move any code around in the bazel workspace, without consuming tests/binaries needing...

@c4urself Sorry for the delay. See the branch at https://github.com/evanj/bazel_rules_pex/tree/pythonroot . I did not send a pull request for this, since it isn't totally clear to me if this is...