bazel_rules_pex icon indicating copy to clipboard operation
bazel_rules_pex copied to clipboard

Added support to honor python imports rules for pex_binaries.

Open srikalyan opened this issue 8 years ago • 6 comments

https://github.com/bazelbuild/bazel/pull/2791 should provide the imports information to skylark and this review uses that information (provided in skylark) to build pex_binaries that honor import.


This change is Reviewable

srikalyan avatar Apr 10 '17 22:04 srikalyan

I could not find a easy way to add this info for pex binary and other pex artifcats. If you could provide some tips, I can get it up and running

srikalyan avatar Apr 10 '17 22:04 srikalyan

Awesome, thank you for the pull request! I'm not sure I understand what you mean by "add this info for pex binary and other pex artifacts" - can you elaborate?

benley avatar Apr 10 '17 22:04 benley

This current implementation only supports pex_binary. Does not support imports for pex_library, pex_test, pex_pytest. Perhaps a pointer can definitely help me add that support.

srikalyan avatar Apr 10 '17 22:04 srikalyan

Sorry for the delay - I haven't forgotten about this, but I haven't had time to return to it just yet.

benley avatar Apr 13 '17 17:04 benley

I guess we're still waiting for bazelbuild/bazel#2791 to get merged...

benley avatar Jun 27 '17 02:06 benley

This has the same motivation as #42 .

evanj avatar Jan 08 '18 20:01 evanj