euri10

Results 238 comments of euri10

this seems to break quite a lots of our tests @guyskk

> And the [caplog_for_logger](https://github.com/encode/uvicorn/blob/master/tests/middleware/test_logging.py#L13) helper also not work on test config cases, because when create Config object, `Config.configure_logging` will remove caplog.handler. > mm this is where I'm not too sure,...

thanks a lot @guyskk @Kludex since you tagged this on the 0.20.0 release I'll let you merge it, or maybe we can point it to this PR release but I'm...

> I think I would need to know more about uvicorn to implement this properly. How does the "queuing" logic work? I'm in the dark as to how requests are...

I'm dubious about this PR, I'm no SSL expert though but this seems like this link explains it quite well : pass a directory containing your CAs : https://docs.python.org/3/library/ssl.html#ssl.SSLContext.load_verify_locations Feel...

Happy to reconsider then effectively, but: 1. add tests 2. change the positional only arg we currently have to kwargs so that we're clear on what location we use

No need it's automatic on the repo iirc

Hi @jchristgit , yeah send us a repro, in that case the trusted host param you are passing and the headers received should be good I think, the None is...

ok I can reproduce, the comment here might be of interest in the PR: https://github.com/encode/uvicorn/pull/591/files#r402461347 so we're in the case where `trusted_host = A` and `X-Forwarded-For: A` if I get...

could do that, this works but not certain of the edge case or implications ``` if self.always_trust or (self.trusted_hosts == set(x_forwarded_for_hosts)): return x_forwarded_for_hosts[0] ```