euri10 comments

Results 238 comments of


                                            euri10

Honor gunicorn access log format

> Now that there is a PR, what would be required to add this functionality? We'd like to match our existing aiohttp-created logs with some new logs created from a...

Honor gunicorn access log format

I answered in the PR @immerrr

get_remote_addr return (str(info[0]), int(info[1])) if isinstance(info, tuple) else None ValueError: invalid literal for int() with base 10: b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'

wont have a windows machine at hand to reproduce that, would you throw up a PR that would make our CI fail ?

Handshaking may not be completed yet at `shutdown` in wsproto impl

Could you please send the command you used? Does it happen without gunicorn? Do you have a minimal example of the code that triggers it? Le sam. 21 mars 2020...

Handshaking may not be completed yet at `shutdown` in wsproto impl

sorry I cant reproduce, am I doing ``` (venv) ➜ uvicorn git:(596_shake) ✗ uvicorn --ws wsproto toto:app --log-level=trace INFO: Started server process [18661] INFO: Waiting for application startup. TRACE: ASGI...

Handshaking may not be completed yet at `shutdown` in wsproto impl

ok sorry I thought kill was sigkill, I reproduced with sigterm and tried a fix but not very happy with it this doenst happen with the other ws implementation though

Handshaking may not be completed yet at `shutdown` in wsproto impl

on a side note thanks for websocat, it rocks

Implement gunicorn access log format

> @euri10 is there anything i can do to help get this in? or at least to help to get the discussion started, as i would assume there's a decision...

Implement gunicorn access log format

> Would the [extensions approach](https://asgi.readthedocs.io/en/latest/specs/main.html#extensions) from the spec work here? I think yes that would be the most sensible thing to do to move things forward.

Implement gunicorn access log format

you can use `./scripts/lint` if you have linter issues, not sure if you saw it