eugineerd
eugineerd
> Would it make sense to just remove querying from this PR entirely, then? The implementation here proves that it's _possible_ to query these, which is important! But removing it...
@alice-i-cecile Now that I've removed `filter_by_component_value` implementation for `Query`, I don't think this needs a release note or new examples anymore? The changes are purely internal now and don't introduce...
Figured out how to disable cpu dynamic boost on my laptop and ran some benchmarks: Benchmarks ``` group fragmenting-value main-no-boost ----- ----------------- ------------- add_remove/sparse_set 1.16 1447.3±34.71µs ? ?/sec 1.00 1243.6±13.78µs...
I've run the benchmarks again to see if anything changed with the latest main. ecs benchmarks with >5% threshold ``` group main value-components ----- ---- ---------------- add_remove_big/table 1.10 3.0±0.11ms ?...
I've rewritten most of this PR to simplify implementation: - Unified `DynamicFragmentingValue` and `dyn FragmentingValue` trait as `FragmentingValue` - Made `FragmentingValueVtable` more FFI/scripting-friendly - Simplified bundle insertion logic - Made...
> although, hmm, from a quick glance at https://github.com/bevyengine/bevy/pull/16132's diff, it looks like ComponentCloneFn can't exactly be used as-is The biggest problem was guaranteeing that `ComponentId`s match between different worlds....
> So, in terms of an API specifically designed for cloning worlds This API design is very similar to what I attempted to do in #17316. I currently don't have...
> > couldn't we implement this by storing the entity of the parent instead of the data and then resolving the data from the entity when it is needed? >...
> From my perspective as an SME-ECS, I want to see very strong motivation for why Bevy and Bevy users need this. I have no doubt that it's well-implemented, but...
@chengts95, would this implementation be good enough for your use case?