Eugene Kenny

Results 18 comments of Eugene Kenny

This seems to be a simpler version of the existing [model filter](https://github.com/cypriss/mutations/blob/v0.8.3/lib/mutations/model_filter.rb) - is there a case where you couldn't use that instead?

`Performance/ChainArrayAllocation` already handles this for arrays: https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancechainarrayallocation

Note that `remove_columns` / `t.remove` will be reversible in Rails 6.1 via https://github.com/rails/rails/pull/36589.

What's happening is that the memory-mapped file is closed before curl has a chance to read it - it's a problem with the xero library, not curl. Here's a patch:...

Mixpanel now offers EU data residency with separate API URLs, which makes needing to change them less of an edge case: https://developer.mixpanel.com/reference/overview > Standard Server: `api.mixpanel.com` > EU Residency Server:...

While mixing HTTP and HTTPS is less common than it used to be, it seems like overreach for us to set a secure cookie whenever the current request is over...

Based on `.travis.yml`, it looks like this gem supports Ruby 2.0 and above: https://github.com/taskrabbit/makara/blob/01195ef2dfd258a53786a4a30a9cbc2aff581e2e/.travis.yml#L19-L26 The safe navigation operator was only added in Ruby 2.3, so we can't use it here.

This is a regression in Ruby 2.4.0: https://bugs.ruby-lang.org/issues/13074 The fix has been backported to the 2.4 branch, so it should be fixed in 2.4.1.