Eugene Kenny
Eugene Kenny
Thanks for writing this up @shayonj - I agree that `discard_empty` isn't documented well enough, given that I didn't know about it until I saw this 😄 I'm not sure...
This does look like it would be useful - sorry it sat unacknowledged for so long 😔 Would you be interested in rebasing this and resolving the conflicts so that...
I've been bitten by this problem before, so I'm into this idea. A few notes: --- Calling `dup` on true, false, or nil raises a TypeError on Ruby < 2.4:...
The method documentation for `add_error` includes this example usage: https://github.com/cypriss/mutations/blob/87d6ecb2d69484751297e42ecc4263f0e31e2bfa/lib/mutations/command.rb#L109 Unfortunately, it doesn't work correctly: the last key isn't converted to a symbol, so the error is added as `[:colors]["foreground"]`...
That does seem like a natural extension to the current API 👍 are you interested in implementing it?
Accepting BigDecimal inputs sounds reasonable 👍 It looks like there are other changes on your branch now though - do you want to remove them so I can merge this...
This seems like it would be a lot of work to implement, in order to satisfy a very specific use case. It would be much easier, if a little uglier,...
I'm still watching the repo, but I haven't had much spare time for this project recently. I'm going to try to make a release over Christmas.
Nice find, @estraph! It looks like this used to work correctly, but broke all the way back in https://github.com/cypriss/mutations/pull/3 🙂 Unfortunately I don't think we can just change it back:...
Inheriting from `HashWithIndifferentAccess` was proposed in https://github.com/cypriss/mutations/pull/48, and rejected with this explanation: > If you have nested hashes in your inputs, and a field in a subhash is invalid, you...