mutations icon indicating copy to clipboard operation
mutations copied to clipboard

Document default behavior of nil and discard_empty for string

Open shayonj opened this issue 8 years ago • 2 comments

We recently learnt about the default behavior of nil and discard_empty for string in optional fields. Adding the same to README, so its easier to reference. From the TODO, looks like it was intended to be added as well :).

shayonj avatar Feb 26 '17 18:02 shayonj

Update commit message, for more clarity.

shayonj avatar Feb 26 '17 18:02 shayonj

Thanks for writing this up @shayonj - I agree that discard_empty isn't documented well enough, given that I didn't know about it until I saw this 😄

I'm not sure the README is the right place for this though: the rest of the content there is a high-level introduction to the library, and this is an in-depth explanation of a somewhat niche feature.

Maybe it should be added to the Filtering Input wiki page?

eugeneius avatar Oct 24 '18 21:10 eugeneius

Its been a while with this PR, I think I will close it for now, thanks for the review @eugeneius, hope you are keeping well 😄

shayonj avatar Jan 10 '23 05:01 shayonj