Eugene Manuilov

Results 144 comments of Eugene Manuilov

> * Using `assets/js/components/ErrorHandler/index.js`, > > * Add a new optional prop `errorMessage` which will be rendered if provided in place of the current rendered markup (`Notification`). > * The...

@asvinb, yes, I understand your intention, but I think we should still use a separate component and not change the `ErrorHandler` component to avoid making even more changes there in...

Thanks, @asvinb. All looks good now, except we don't need tracking for the new error handler. I have removed it from IB. IB ✔️.

> * Update the `User_Input_Settings::get_settings` with the following logic: > > * Remove the existing logic. > * Retrieve the settings from the `parent::get` method. > * Return the settings...

Thanks, @hussain-t. IB ✔️

> * Find instances of `isModuleActive( MODULES_TAGMANAGER )` and first check for `isModuleAvailable( MODULES_ANALYTICS )` (do the same with `MODULES_TAGMANAGER`). @tofumatt why do we need to check whether the Analytics...

This is a nice addition that will help to improve some code quality. However my concern is that it will require a lot of refactoring of existing functions, especially those...

> * Check if Analytics and Search Console are connected using the `isModuleConnected` selector. @hussain-t this is not sufficient because we also need to make sure that these modules are...