Eugene Fidelin
Eugene Fidelin
Any plans to implement this fix?
I signed it!
The main problem is that Redis KEY command (http://redis.io/commands/keys) that is used to search for keys doesn't support any pagination. So if you have 100000 keys - all of them...
Now all keys are fetched using KEY command to the PHP array. But, as i mentioned above, this could lead to memory allocation error in case of huge databases. Also...
Every search we will create snapshot of the keys that meet search criteria. Keys are returned in no order (i think in order they are stored in memory) so the...
Simple scenario - if you have more than 10000 search results it is better to paginate them or browser can crash. Pagination is needed to prevent such an issue even...
First, You can't guarantee that end-users will use your software in a "proper" way and won't use search for the all keys on a big dataset. Second, for example now...
Hi @sasanrose, i do not agree with you. Because namely without pagination phpredmin can cause DDOS attack on the server. Now if you have 2 million keys and search for...
To have some estimation on memory usage i have created several test scripts: http://3v4l.org/6tIHi - for 100000 keys http://3v4l.org/5PlNa -for 150000 keys Average key length is 20 characters. As you...
@romeovs could you please release a new version of this github action that contains the fix.