Yubi Lee

Results 31 comments of Yubi Lee

How about changing ```decodeURLEncodedURIComponent``` -> ```decodeURIComponent``` in for loop? I may misunderstand but I found that this changes `+` sign in url to `%20` (empty space) unnecessary. (Unnecessary twice call...

@heymagurany ~~Hello, I think just making `decodeURLComponents` to `false` is not proper solution.~~ (https://github.com/visionmedia/page.js/pull/348#issuecomment-552688558) ~~The PR you tried to fix this problem should be merged.~~ Fix: Oh I understand now....

https://github.com/visionmedia/page.js/blob/master/index.js#L794-L806 Duplicate decoding still exists.

Build failure is caused by SSL expiration on https://maven.java.net/content/repositories/snapshots site, not because of this PR.

AMBARI-24695, AMBARI-24693, AMBARI-24707 should be adopted to `branch-2.7` in order to build `AMBARI-2.7.6`. Also, I found a bug when enabling kerberos with ambari 2.7.6. I plan to make a contribution...

@brahmareddybattula I made a patch to fix the bug. https://issues.apache.org/jira/browse/AMBARI-25719 https://github.com/apache/ambari/pull/3344

@brahmareddybattula I think AMBARI-24695, AMBARI-24693, AMBARI-24707 should be adopted also to build ambari with branch-2.7. Should I make a separate PR for these? It seems awkward to make another PR...

build failure is caused by broken link to ambari metrics package. >[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (default) on project ambari-metrics-timelineservice: An Ant BuildException has occured: Can't get https://private-repo-1.hortonworks.com/HDP/centos7/3.x/updates/3.1.4.1-1/tars/hbase/hbase-2.0.2.3.1.4.1-1-bin.tar.gz to...

If `compressImageQuality` is not 1.0, it makes rotation twice. https://github.com/ivpusic/react-native-image-crop-picker/blob/master/android/src/main/java/com/reactnative/ivpusic/imagepicker/Compression.java#L40-L42

Hello. Yes you can move this to trunk. However, I found some issues with that PR and forgot to add unit tests. I'll fix it. Should I make a PR...