Bob Ippolito comments

Results 283 comments of


                                            Bob Ippolito

fix: delete horizontal node in table cell node

Are you planning to finish up this PR?

Bug: block cursor shown instead of normal one

This is still reproducible, whatever heuristic is being used to remove the block cursor just isn't getting triggered when it gets stuck in this state. I think it has something...

[lexical-react] Fix(lexical-react): ContentEditable props type rename

I think this probably makes sense but it doesn't maintain backwards compatibility. I would recommend also exporting it as Props, maybe with a `@deprecated` docstring

Bug: Is the LexicalNode isBefore logic correct?

I was also confused by this logic the last time I was looking into it. IIRC it might have something to do with the node being entirely before, not just...

Bug: Shift+down selects an extra subsequent element

Tbh I think selection has a lot of broken edge cases when it's not a RangeSelection of text. Haven't recently taken a close look at any of them.

[playground] Bug: viewport of image imported from Markdown is way larger than viewport of same inserted image. Imported image then can overflow the editor bounds - instead a horizontal scroller is needed or some other solution, but not image overflowing the editor viewport

For whatever reason the default image maxWidth in the playground is 500px but the default image maxWidth when importing from markdown in the playground is 800px. If you change those...

Bug: in Playground typing in markdown source box, actually jumps and chars start appear outside this source box

It looks like you can reproduce this if you get an element selection on the root element, repro is: 1. Clear playground 2. Click on M↓ 3. Type something 4....

fix: the problem where text inserted into a node with a leaf node wo…

It looks like this is currently the intended behavior, there's a test for it that's failing with this implementation ``` 1) [chromium] › packages/lexical-playground/__tests__/e2e/CopyAndPaste/html/LinksHTMLCopyAndPaste.spec.mjs:267:3 › HTML Links CopyAndPaste › Paste...

fix: the problem where text inserted into a node with a leaf node wo…

The current test case puts text on the clipboard and pastes it into the link and expects the split node behavior. I don't have any knowledge of the decision making...

Improve React Getting Started Documentation

Since we do have a getting started guide that does link out to stackblitz I think this can be closed