lexical icon indicating copy to clipboard operation
lexical copied to clipboard

[lexical-react] Fix(lexical-react): ContentEditable props type rename

Open ivaaaaann opened this issue 1 year ago • 3 comments

Description

The name of the type seems too generic, so I suggest renaming it to:

Like the link below https://github.com/facebook/lexical/blob/main/packages/lexical-react/src/LexicalTablePlugin.ts

ivaaaaann avatar Nov 15 '24 07:11 ivaaaaann

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 0:59am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 0:59am

vercel[bot] avatar Nov 15 '24 07:11 vercel[bot]

size-limit report 📦

Path Size
lexical - cjs 30.85 KB (0%)
lexical - esm 30.73 KB (0%)
@lexical/rich-text - cjs 39.58 KB (0%)
@lexical/rich-text - esm 32.67 KB (0%)
@lexical/plain-text - cjs 38.22 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.35 KB (0%)
@lexical/react - esm 34.03 KB (0%)

github-actions[bot] avatar Nov 15 '24 07:11 github-actions[bot]

I think this probably makes sense but it doesn't maintain backwards compatibility. I would recommend also exporting it as Props, maybe with a @deprecated docstring

etrepum avatar Nov 15 '24 16:11 etrepum

@etrepum Thanks for the nice comment, I didn't think about that part! I modified it according to your comment.

ivaaaaann avatar Nov 16 '24 05:11 ivaaaaann