Etienne Bacher

Results 141 comments of Etienne Bacher

> ```r > x2 ``` To me this is really confusing, I would think it's decreasing by `cyl`

> An alternative would be to just have `ascending` and `descending`, and only variables specified in one of those arguments will be used for sorting, so we can skip `select`...

> ```r > x2 ``` I don't want to be the guy who criticizes every single idea except mine :grimacing:, but this looks even weirder to me and it makes...

> On the other hand, how many real-world use cases exist where you sort by more than 1 or 2 variables? I agree 100% on that, which is why I...

Looks good to me too, but it's a bit hard to read most function names in steps 2 and 3. Maybe you can remove the very small ones to increase...

> Can we merge this? I think we should go with the design that @etiennebacher suggested first, for consistency, I just used a select argument instead of dots. I'm ok...

These functions are not used in `datawizard` or `report`. Should we remove them? They're not hard to reimplement if needed

Is this issue still on the todo list or was it superseded by #45 and the new function `data_tabulate()`?

I can try to do something in the next days