datawizard icon indicating copy to clipboard operation
datawizard copied to clipboard

Published 20 hours ago • verified publisher icon easystats

Should we be exporting string utilities?

Open IndrajeetPatil opened this issue 2 years ago • 3 comments

They have been there for a while in the internals, but I am not sure if they are actually useful in the ecosystem or just general purpose utilities that might be helpful for some:

https://github.com/easystats/datawizard/blob/776856fd688502ffed02f7ebe09a87ae7f6b4d24/R/utils_strings.R

IndrajeetPatil avatar Mar 14 '22 21:03 IndrajeetPatil

@strengejacke Do we need any of these, or can I remove them?

IndrajeetPatil avatar Mar 17 '22 12:03 IndrajeetPatil

not sure, are these in use anywhere in datawizard? Else, remove.

strengejacke avatar Mar 17 '22 13:03 strengejacke

we should rename them text_* to go with the others but keep them, I reckon it might be useful in the future in report & co

DominiqueMakowski avatar Mar 17 '22 13:03 DominiqueMakowski

These functions are not used in datawizard or report. Should we remove them? They're not hard to reimplement if needed

etiennebacher avatar Sep 05 '22 15:09 etiennebacher

Yeah, let's remove them. Want to make a PR?

IndrajeetPatil avatar Sep 05 '22 15:09 IndrajeetPatil

yup

etiennebacher avatar Sep 05 '22 15:09 etiennebacher