curves icon indicating copy to clipboard operation
curves copied to clipboard

Fixing compilation in Debug mode.

Open pfankhauser opened this issue 7 years ago • 6 comments

This fixes the unit quaternion check when building in Debug, however it breaks the unit test at

/home/peter/catkin_ws/src/curves/curves/test/CubicHermiteSE3CurveTest.cpp:261:

Couldn't figure out what goes wrong here, any ideas?

pfankhauser avatar Mar 24 '17 17:03 pfankhauser

Can one of the admins verify this patch?

ethzasl-jenkins avatar Mar 24 '17 17:03 ethzasl-jenkins

@pfankhauser isn't Jenkins setup to verify PRs? I'll try on my machine.

rdube avatar Mar 28 '17 09:03 rdube

@pfankhauser I get the same issue, with the rotational part failing. Which part of the modif did solve the building in debug? The new construction of the w1_dbeta1 ... objects or the construction of qDiff with normalization? Are you sure that both modifs are needed and maybe we can use this to isolate? Also which constructor of https://github.com/ethz-asl/kindr/blob/9a0d954636278e79b62e21a2ea4d7d664265f5be/include/kindr/rotations/RotationQuaternion.hpp#L55 is used? I could not find one taking a 3x1 eigen matrix.

rdube avatar Mar 28 '17 09:03 rdube

@dbellicoso what's the state of this with your latest fixes?

pfankhauser avatar May 29 '17 08:05 pfankhauser

add to whitelist

helenol avatar Aug 22 '17 08:08 helenol

I've killed the curves_tests on ibex-trusty after it had consumed > 700 minutes of CPU time...

HannesSommer avatar Oct 24 '17 06:10 HannesSommer