curves
curves copied to clipboard
Fixing compilation in Debug mode.
This fixes the unit quaternion check when building in Debug
, however it breaks the unit test at
/home/peter/catkin_ws/src/curves/curves/test/CubicHermiteSE3CurveTest.cpp:261:
Couldn't figure out what goes wrong here, any ideas?
Can one of the admins verify this patch?
@pfankhauser isn't Jenkins setup to verify PRs? I'll try on my machine.
@pfankhauser I get the same issue, with the rotational part failing. Which part of the modif did solve the building in debug? The new construction of the w1_dbeta1
... objects or the construction of qDiff
with normalization? Are you sure that both modifs are needed and maybe we can use this to isolate? Also which constructor of https://github.com/ethz-asl/kindr/blob/9a0d954636278e79b62e21a2ea4d7d664265f5be/include/kindr/rotations/RotationQuaternion.hpp#L55 is used? I could not find one taking a 3x1 eigen matrix.
@dbellicoso what's the state of this with your latest fixes?
add to whitelist
I've killed the curves_tests
on ibex-trusty after it had consumed > 700 minutes of CPU time...