3dsnet icon indicating copy to clipboard operation
3dsnet copied to clipboard

Possible typo in adaptive norm

Open qiminchen opened this issue 3 years ago • 2 comments

Line 351/354 and line 359/362 should be norm2 and norm3?

https://github.com/ethz-asl/3dsnet/blob/e823742eb781a01906760bbf28ccab94b1f0bb14/model/meshflow.py#L338-L362

qiminchen avatar Jun 25 '21 19:06 qiminchen

I think it's a typo too. the layer norm2 norm3 are not utilized in the forword

csjxchen avatar Aug 31 '21 09:08 csjxchen

Hi @qiminchen and @csjxchen, sorry for not replying before! This definitely is a typo :)

If you are working on it, you could simply make a PR to fix it and adjust ckpt weights. I will look into it as soon as I find time.

mattiasegu avatar Sep 06 '21 09:09 mattiasegu