towr
towr copied to clipboard
A small bug in HeightMap::GetDerivativeOfNormalizedBasisWrt()
Hello,
I believe I found a bug in HeightMap::GetDerivativeOfNormalizedBasisWrt().
The code below
Vector3d dn_norm_wrt_n = GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, dim);
return dn_norm_wrt_n.cwiseProduct(dv_wrt_dim);
should be replaced by
Eigen::Matrix3d dn_norm_wrt_n;
dn_norm_wrt_n << GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, 0),
GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, 1),
GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, 2);
return dn_norm_wrt_n * dv_wrt_dim;
Am I correct? Please confirm. Thanks.