control-toolbox icon indicating copy to clipboard operation
control-toolbox copied to clipboard

Fix for UnscentedKalmannFilter

Open condor-cp opened this issue 3 years ago • 3 comments

I wasn't able to run the UnscentedKalmannFilter without these two modifications :

  • Run the method "computeWeights" in the constructor
  • Change the signature of computePredictionFromSigmaPoints to return an Eigen vector and not assume it is a state_vector or output_vector.

I guess the problems remained undetected because in the test built for Kalmann Filtering, STATE_DIM == OUTPUT_DIM == 2

condor-cp avatar Jun 16 '21 01:06 condor-cp

Should I do this pull request in the v3.0.3-devel branch ?

condor-cp avatar Jul 01 '21 20:07 condor-cp

re-running unit tests.

markusgft avatar Jul 05 '21 07:07 markusgft

I just rebased my fork on the upstream v3.0.2 since the PR was not applied. I also added a commit to make hpipm mode configurable.

I thought the current PR would have been unaffected but I see it mirrored the changes I made in my forked branch.

condor-cp avatar Mar 28 '22 16:03 condor-cp