Edward Thomson

Results 283 comments of Edward Thomson

Sorry, can you provide a little more detail of what you're doing, the precise error messages, etc?

Like git, we load the entire file into memory when CRLF filtering is enabled to do the conversion. Although this is a terrible design, it is by design.

How could we help you here? We could have a size limit for files that we reject filtering for. This would prevent OOM crashes, at least.

Thanks for the report. `safe.directory` is going to shape up like `core.autocrlf`; a gift that keeps on giving. 😬 Apparently wildcard support was introduced in git 2.35.1, which we can...

This is indeed reasonable, but it seems like an API addition and not something that we explicitly need for a stable API.

Hi @Totktonada ! Thanks for opening this issue. At the moment, [the documentation](https://docs.github.com/en/actions/advanced-guides/caching-dependencies-to-speed-up-workflows#output-parameters-for-the-cache-action) states: > cache-hit: A boolean value to indicate an exact match was found for the key. Can...

I'd like to see one, too. @bording do you have any interest in publishing a new release proper? I'm happy to do it if you're busy.

It's definitely something that we should include, but I do not have a timeline for doing so.

> Set safe.directory to * rather than a specific path in this action. I think that's safe... Unfortunately, there's a window of git versions that have the new `safe.directory` handling...

Hi @torvalds -- many thanks for the bug report and the fix -- and apologies that it's taken so long to address this, it's been a busy summer. I made...