Edward Thomson

Results 283 comments of Edward Thomson

You're kind to say that. But you've not wasted my time at all. I expect libgit2 to compile cleanly with no warnings out of the box, at least on Linux,...

> @ethomson just looking at recent commits, it seems like you are the best at making things happen in libgit2 - can you comment on if this is a reasonable...

Hi @julianmesa-gitkraken - here, too, I don't know. Even in the timeline view it says it was closed after your query. I'm stumped. 🤷‍♂️

I made some updates to remove the API breaking parts of these changes; this should be ABI breaking only.

@dcecile to the best of my knowledge, no `git clone` is never doing retries. It may be timing out though (per this issue) and so you would see git and...

> Why git_remote_ready_cb remote_ready; is not defined as GIT_CALLBACK()? It is - https://github.com/libgit2/libgit2/blob/258df9c18d4876ad59a2cfa9d78a313f867d633e/include/git2/remote.h#L538 ? 🤔

I think that we can probably ditch the variadic macro and do something a little grosser. I was hoping to avoid making the `git_str` super magical, but you can imagine...

Hi @olsen232! This seems reasonable, but I'd like to take a deeper look soon 🔜 👀, as soon as we push v1.4.0 out. Exciting stuff!

Hi Greg - I'm not sure that I understand your question. You should be literally using `${{ secrets.GITHUB_TOKEN }}`, which is the [expansion syntax](https://help.github.com/en/articles/contexts-and-expression-syntax-for-github-actions) to use the [GITHUB_TOKEN secret](https://help.github.com/en/articles/workflow-syntax-for-github-actions) which...

> Cool, I think it's still worth building with libssh2. To be clear up front: this is ultimately Your Decision, not mine. 😁 But I do want to give some...