Edward Thomson

Results 549 comments of Edward Thomson

Very good question. It wonder if we can do something clever here that fixes two problems: 1. These are text docs / markdown and so easy to get out of...

Sorry for the delay, things are a bit hectic getting ready for [GitHub Universe](https://githubuniverse.com/). This is the first time we've done something like this (but I hope not the last),...

Thanks for the ping. I’m working on changing the way that we handle starter workflows - I hope to have more information for you :soon:

I agree. I added some code to do the validation in my serverless extension: ``` const validateSignature = (req) => { const given = req.headers['x-hub-signature'] || req.headers['X-Hub-Signature'] if (! process.env['WEBHOOK_SECRET'])...

@rthadur No, and I was never intending to. I was commenting here since I had the same issue in my serverless extension for Azure Functions: https://github.com/ethomson/probot-serverless-azurefunctions I did deploy my...

Do you know offhand whether MSVC supports VLA and if so, when that support started? `alloca` sort of sucks, but it's _mostly_ portable. (Having to include `alloc.h` is hardly a...

They've been slowly chipping away at improving their C compiler. I'll take a look and see where VLA support starts and we can decide how we should attack this. (Could...

I'm going to close this for now; if / when we run into an architecture that lacks `alloca` we should figure this out for reals.

> If the ABI is stable perhaps there is no need to keep bumping the soname? The ABI isn't stable. I think that this is a good effort, and one...

@carterbox Yeah, we've probably ignored this issue for too long. We probably invest in getting this right.