Edward Thomson comments

Results 549 comments of


                                            Edward Thomson

fingerprint_type_mask returns typemask before checking keytype?

I understand what you're saying. That function either needs to not `return mask2` or to have the rest of the lines removed. (cc @carlosmn) But again - what you're reporting...

fingerprint_type_mask returns typemask before checking keytype?

Here's the original bug report: https://github.com/libgit2/libgit2/issues/6453

fingerprint_type_mask returns typemask before checking keytype?

Thanks @vytasmk! I hope that you don't mind, I'm going to keep this open since it _is_ an issue, but I also think that we've sorted out the issue that...

Export CMake target

@pks-t has been doing a lot of work on cmake so having his set of eyes would also be helpful. :)

Support ~/.ssh/id_rsa or ~/.ssh/config

If you're willing to open a PR with libssh support, of course, then I'd be perfectly happy to include it. Otherwise, I'd prefer to stop using libssh2 or libssh and...

Support ~/.ssh/id_rsa or ~/.ssh/config

Closing since OpenSSH is now an option

Tree lookup fails with "fake" repositories since 1.6.1

Fixed via #6554

Cloning large repo in libgit2 slower than `git clone`

Yep, apologies but I've been making incremental progress on this in a branch.

known_hosts fails to load on Android

Backing up - do you _have_ a known hosts file that's failing to load? Or does the file exist? Is it valid and able to be read by ssh? (I...

known_hosts fails to load on Android

~Also, I'm not sure what numbers like (`622`), (`548`), etc are indicating. Are those line numbers?~ Nevermind, after rereading, I'm understanding how they refer back to the previous file:line_number mapping.