Tzu Gwo comments

Results 98 comments of


                                            Tzu Gwo

Fully Asyncio Support

Yeah I think it can be merged smoothly, I just resolved the last little conflict.

@wooparadog The different between two pull requests is they realized different transport (I support bufferd and #299 supports memory bufferd). In my opinion, the buffered transport realization is more difficult...

0.4.14 has a problem about MergeFromString(rst.response_data)

how to reproduce it?

Python 3.7: RuntimeError: read() called while another coroutine is already waiting for incoming data

There is not a reporting before, I will try to reproduce your case, thank you

"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

I am not sure that replacing `asyncio.coroutine` with `types.coroutine` would not break the compatibility of Python 3.4 or lower version. I will test it later.

"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

https://pypistats.org/packages/thriftpy2 shows that there are some users still use 3.4 in current, if we migrate to async def, I think we should release a major version.

"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

@aiudirog thank you so much, i am glad to see your help.

"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

@aiudirog it looks good to me, thanks

Add enum constructor to create enum from value

Yes, I think it is better to have the same behavior as https://docs.python.org/3/library/enum.html

Create issues for each missing feature to ease collaboration

Thank you, I am glad to see your interest. I post some incomplete features in README, such as directive support, custom scalar types. If you have time to look at...