Tzu Gwo
Tzu Gwo
I think maybe I have to revert this merge #139 and have a discussion again about the binary type support
Hold this issue before Apache JSON protocol re-merge.
@JonnoFTW Thanks for your work! I have several suggestions: - could you split support the Binary type feature and Apache JSON protocol to two pull requests? - we should ensure...
There is still not yet, I will concern about implement it.
I think maybe there are some ways to walk around in current, thriftpy2 will raise a socket exception when connection lost.
See https://github.com/Thriftpy/thriftpy2/blob/master/thriftpy2/contrib/aio/socket.py#L342 .
I think making TAsyncBinaryProtocol inherit from asyncio.BaseProtocol directly is fine to me, and you can overload the connection_lost method to customize the behavior. However, I think it is a little...
Yes, it could be. Passing into a call back function by the user and check if there is a call back function exists is feasible.
You could write your custom transport to realize it, thriftpy does not provide a built-in udp transport yet, and if you realize it, please contribute it back to thriftpy, thanks.
Hi all, I accept https://github.com/markmnl/thriftpy/commit/0801f462c044e2def9a305b38f77fb89ead2c6cb in [thriftpy2](https://thriftpy.github.io/thriftpy2/) to fix it, thanks!