Ethan Sharabi comments

Results 65 comments of


                                            Ethan Sharabi

replace moment for smaller bundler

> TBH I did not test it because I assumed we still need `moment` in private anyway, so it'll just add another dependency and not really help us. > Another...

StackAggregator - fix children update

@Inbal-Tish I noticed that the first time you open the stack it doesn't have an animation. It works fine on the master version

Toast is displayed under the Dialog component

Hi @mohamedGamalAbuGalala Can you please share a code snippet and maybe a screenshot/video Thanks

bundle's entry file names `demo.js` not `index.js`

@Guang1234567 What fail exactly? What and how are building the app

Demo App dependency missing issue

which folder do you run `npm start` from?

can not run example

run the following ``` npm install cd ios && pod install && cd .. npm start // on another terminal npm run ios ```

Dark mode view modifiers no longer working

@lidord-wix Let's add this to our docs. Under Foundation -> Colors

Add versioning for docs at Major bumps

That's a great idea. We are currently working on migrating our docs to Docusaurus so later on this is something we can check out

Formatting of Incubator.ChipsInput wrong if on more than one line.

Hi @btrewern I believe this issue was fixed in this PR #2183 Can you please verify and reopen the ticket if needed

Card : Shadow is still enabled when defining a containerStyle in ThemeManager

> Hi @RaphBlanchet, > > The problem occurs because we have `defaultProps` for `Card` that sets `enableShadow: true`. You can solve it by using `setComponentForcedTheme` instead of `setComponentTheme`, but then...