react-native-ui-lib
react-native-ui-lib copied to clipboard
replace moment for smaller bundler
Description
Enter description to help the reviewer understand what's the change about...
Changelog
Add a quick message for our users about this change (include Compoennt name, relevant props and general purpose of the PR)
@ethanshar we probably cannot merge this as-is, but perhaps we can create an optional-dependency for this?
@M-i-k-e-l Why not use this light package instead? Does it work the same as moment in this case?
TBH I did not test it because I assumed we still need moment
in private anyway, so it'll just add another dependency and not really help us.
Another thing to consider is users will need to migrate and this should be done in a major version.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
TBH I did not test it because I assumed we still need
moment
in private anyway, so it'll just add another dependency and not really help us. Another thing to consider is users will need to migrate and this should be done in a major version.
I think we should consider using the light-date package. For our public users it makes sense not to have them install moment And for our internal case it's redundant since it's a light package anyway
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.