react-native-ui-lib icon indicating copy to clipboard operation
react-native-ui-lib copied to clipboard

replace moment for smaller bundler

Open ekoeryanto opened this issue 3 years ago • 6 comments

Description

Enter description to help the reviewer understand what's the change about...

Changelog

Add a quick message for our users about this change (include Compoennt name, relevant props and general purpose of the PR)

ekoeryanto avatar Jan 25 '22 16:01 ekoeryanto

@ethanshar we probably cannot merge this as-is, but perhaps we can create an optional-dependency for this?

M-i-k-e-l avatar Mar 23 '22 07:03 M-i-k-e-l

@M-i-k-e-l Why not use this light package instead? Does it work the same as moment in this case?

ethanshar avatar Apr 03 '22 08:04 ethanshar

TBH I did not test it because I assumed we still need moment in private anyway, so it'll just add another dependency and not really help us. Another thing to consider is users will need to migrate and this should be done in a major version.

M-i-k-e-l avatar Apr 03 '22 08:04 M-i-k-e-l

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 04 '22 00:06 stale[bot]

TBH I did not test it because I assumed we still need moment in private anyway, so it'll just add another dependency and not really help us. Another thing to consider is users will need to migrate and this should be done in a major version.

I think we should consider using the light-date package. For our public users it makes sense not to have them install moment And for our internal case it's redundant since it's a light package anyway

ethanshar avatar Jun 06 '22 12:06 ethanshar

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 10 '22 02:08 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 09 '22 10:11 stale[bot]