eth3lbert

Results 51 comments of eth3lbert

A script like the following, which leverages `delta`, could be helpful for reviewing the changes. This script would compare the new implementation to the old one. ```python import sys from...

Thanks! This PR definitely took some time to review, so I appreciate it.

> but it's somewhat hard to decide in which direction we should move forward if we did so I highly recommend checking out `svelte/svelteKit`. Its simplicity and easy learning curve...

Digging into the failure a bit further, to make the test pass, you need to: 1. Make the response reflect the sorting method: Add support for sorting by `recent-downloads` in...

I've also get around this by utilizing the `fzf` picker which provide query and auto select the only match functionality. e.g. `cargo run -- --picker fzf --picker-args --select-1 --query 311...

This would be quite interesting. Currently, uv downloads and builds the source but doesn't store the source archive. In this case, I'm not sure how to recompute the hash if...

I thought you could use [scripts](https://devenv.sh/scripts/) to achieve something similar.

Thanks for the review! I'll integrate this change into our CI in a follow-up PR. --- After this PR is merged, should we skip the overlapping Ember tests that have...

A couple of comments, but overall this looks good to me! 👍

I also noticed that since we don't have an index on `expired_at`, I'm not sure how long`find_tokens_expiring_within_days` will take. We might need to investigate this further in production.