Evan Teran
Evan Teran
I understand that what you are doing is sensitive. Any chance you can narrow down the issue in some kind of minimum reproducible example? Unfortunately, I can't do much to...
OK, well that helps a little bit. I can see where in there are possible memory errors and add some extra asserts to try to narrow it down.
Hmm, so I've looked at the code in that routine and there's not a ton to go on at the moment. There aren't many memory references to possibly be null...
Interesting. This is super helpful. I can definitely make the code a little more resilient here. Obviously, it is assuming that `currentThread()` (and process too) never returns `NULL`. There is...
Looks like it fails here: ``` --- FAIL: TestCompressorWildcards (0.01s) --- FAIL: TestCompressorWildcards/defaults (0.00s) ``` So perhaps I just need to update the tests now that some other things are...
@VojtechVitek , @Neurostep I updated the tests and now things pass locally. However, it looks like perhaps the CI workflow didn't rerun on github?
@Neurostep / @VojtechVitek Just wanted to follow up to see if there was anything you need on my end to help move things to the next steps.
@Neurostep / @VojtechVitek I don't mean to bug, but it's been over 9 months. @Neurostep already reviewed it once, is there any likelihood of this being re-reviewed and merged anytime...
Here's a link to the PR: https://github.com/go-chi/chi/pull/921 It does two things: 1. it makes the default list reuse the same logic as the custom list so it also supports wild...
@VojtechVitek don't mean to bug, but I just wanted to check in. The PR is currently waiting for approval to run the CI workflow. If you're busy, no worries, just...