chi icon indicating copy to clipboard operation
chi copied to clipboard
verified publisher icon go-chi

changed the NewCompressor logic to be support wildcards in the defaul…

Open eteran opened this issue 1 year ago • 5 comments

  • changed the NewCompressor logic to be support wildcards in the default set like it already did for a custom list by reusing that logic
  • made defaultCompressibleContentTypes contain "text/*" as all text mime types are arguably very compressible added
  • application/xml to defaultCompressibleContentTypes since it is also a common XML mime type

eteran avatar Jun 12 '24 14:06 eteran

@Neurostep can you help review this please?

VojtechVitek avatar Jun 28 '24 14:06 VojtechVitek

Looks like it fails here:

--- FAIL: TestCompressorWildcards (0.01s)
    --- FAIL: TestCompressorWildcards/defaults (0.00s)

So perhaps I just need to update the tests now that some other things are being compressed. I'll see if I can fix it real quick

eteran avatar Jun 28 '24 16:06 eteran

@VojtechVitek , @Neurostep

I updated the tests and now things pass locally. However, it looks like perhaps the CI workflow didn't rerun on github?

eteran avatar Jun 28 '24 16:06 eteran

@Neurostep / @VojtechVitek

Just wanted to follow up to see if there was anything you need on my end to help move things to the next steps.

eteran avatar Jul 11 '24 19:07 eteran

@Neurostep / @VojtechVitek

I don't mean to bug, but it's been over 9 months. @Neurostep already reviewed it once, is there any likelihood of this being re-reviewed and merged anytime soon?

eteran avatar Mar 28 '25 14:03 eteran