Emily S
Emily S
And just make sure you document that the obsolete hapi package support is untested and deprecated so that users know they are using its instrumentation it at their own risk.
Thanks for reporting this @maxfelsher We'll have an update soon.
@bmaeser What is the `Backup::Logger` object? Did you define it yourself? The logging mechanism of the Ruby client assumes that logger objects implement the basic methods, including `info?` Can you...
One option is to open an issue with the `backup` gem repo and asking them to include the predicate methods `warn?`, `debug?`, `info?` on their `Logger` object. Then it will...
Hey @plantfansam, I thought I'd chime in here, after having worked on the instrumentation of this gem for the Elastic APM ruby agent. Here is our [implementation](https://github.com/elastic/apm-agent-ruby/blob/main/lib/elastic_apm/spies/elasticsearch.rb#L42-L79) Our instrumentation needs...
@AlexanderWert What if the agent doesn't detect the apm server version, how can it know which field to send?
Thanks, @felixbarny. @AlexanderWert if you agree, I'll update the description to reflect Felix's input.
@webmat We discussed this issue in our agents meeting yesterday. We were wondering if you could comment on the compatibility of the proposed format for `labels` with ECS? @simitt Would...
Hi @dblock, thanks for your response. New Relic doesn't use ActiveSupport::Notifications (perhaps because they support back to a version before Grape introduced it?). They instead use [the alias strategy](https://github.com/newrelic/rpm/blob/master/lib/new_relic/agent/instrumentation/grape.rb#L127-L147) that...
Ok, I think what we'll do is: 1. Have a single-line stacktrace for older versions as proposed above. 2. Open a PR to move `@block.call(self)` to its own method so...