estherbuchwalter

Results 8 comments of estherbuchwalter

I don't think that this overlaps with recently merged #2310. #2310 focused on adding Javadoc param tag descriptions and fixing Javadoc related errors.

@cgivre, when you get a chance, would you please be able to look at this PR? I plan to add methods to overload the ones that have multiple inputs in...

Ok, thank you for the review. I used `VarCharHolders` because that's what had been used for the Math UDFs that I am overloading. Yes, I'll add some unit tests with...

@cgivre Thanks for the reminder about the headers!

As of now the random() method that accepts a seed only accepts input of type `int`. Does it make sense to allow the random(int seed) to accept type `double`/`decimal` as...

The functions are designed to accept a VARCHAR which can be an INT, BIGINT, DOUBLE, or DECIMAL.

@paul-rogers, thank you for your question. Please let me know if this explanation satisfies your question. In order to maintain precision, each input is parsed to Java type `DOUBLE` (with...

To clarify, the purpose of this PR is to make Drill more resilient with different types of input to Math functions. The goal here is that Drill should not throw...