est31 comments

Results 666 comments of


                                            est31

Remove the requirement for `std::io::Seek` for PacketReader etc.

> When it was found in the midst of the buffer read, the pointer of underlying reader should be moved back so that the subsequent process can read the content...

Remove the requirement for `std::io::Seek` for PacketReader etc.

> require BufRead instead of Read, or write an extra caution on the document? That'd be the best option imo. I'm not that convinced that the `Seek` requirement is that...

Remove the requirement for `std::io::Seek` for PacketReader etc.

@florian1345 that proposal sounds good! You are welcome to file a PR :).

Dealing with junk at the end of a file?

See also https://github.com/RustAudio/lewton/commit/eb231f72d90e01fa2c0bab59e6cda87a38bf4078

UntilPageHeaderReader may capture a position where it's not actually a beginning of a page

Do you have any real world data that contains `OggS`? Any real world use case? Generally the point of a magic is that it's, well, magic and the sequence that...

UntilPageHeaderReader may capture a position where it's not actually a beginning of a page

Is your proposal to silently ignore hash mismatches and continue the search? What if there is a legitimate hash mismatch then? I think it'd be better to error in that...

UntilPageHeaderReader may capture a position where it's not actually a beginning of a page

> One of the most simple example is when the comment header contains a text "OggS". Hmm that's a good point. During normal operation it's not an issue I guess,...

BasePacketReader is badly-behaved if read_packet is not continually drained

Yeah there is only limited buffering. Maybe this should be pointed out.

`no_std` support

Interesting crate! I'm just a bit worried that it has no users on crates.io apparently. I wonder if there are crates that do the same with more users.

`no_std` support

`core_io` is the only one with actual users, but it seems to require nightly, so isn't really an option. What about rolling our own traits? They shouldn't be too complicated.