ogg icon indicating copy to clipboard operation
ogg copied to clipboard

BasePacketReader is badly-behaved if read_packet is not continually drained

Open Ralith opened this issue 3 years ago • 2 comments

Pushing every page of a complete ogg file before attempting to read any packets will result in lost packets.

Ralith avatar Jan 28 '22 23:01 Ralith

Yeah there is only limited buffering. Maybe this should be pointed out.

est31 avatar Jan 29 '22 02:01 est31

It is very convenient when coupling push-based and pull-based interfaces to push all your data before trying to drain packets, so having undocumented breakage there is definitely an unpleasant surprise.

Ralith avatar Jan 29 '22 02:01 Ralith