Ed Snible

Results 66 comments of Ed Snible

I can verify the bytes that are trying to be decoded are a valid protobuf and match what I sent. ```bash python -c "print(''.join('{:02x}'.format(c) for c in [18, 36, 18,...

@marcusirgens What was the rationale for replacing `frame` with `anypb.Any` in _handler.go_?

@ericvn Is the expectation that UX, who wrote the analyzers, contribute those directories? I had hoped a tool made them from _galley/pkg/config/analysis/msg/messages.yaml_, and that we just improved them. However, I...

@jasonwzm are you still working on this? cc @frankbu This seems important, so I have added myself.

Four of the messages are no longer generated by Istio and should be removed from the docs: IST0114, IST0115, IST0120, IST0121 Twelve messages are still generated and lack detail pages...

@jasonwzm I wrote docs for all of the codes except 126. It seemed complicated, so I decided to leave it for the original analyzer author -- you.

@jasonwzm If you remove 126's logic, remove 126 from messages.yaml and close this Issue.

Can you attach the Trace JSON to this issue so that I can try it? (Click the "Trace Timeline" dropdown on the upper right, select Trace JSON).

> Filters should return values defined in the ABI, not enum values from Envoy. Can you point me to the authoritative ABI return values list?

I am also trying to understand how to read this. I see `proxy_on_http_request_body` returns `i32 (proxy_action_t) next_action`. I suspect the actions are the enumerations defined in https://github.com/envoyproxy/envoy/blob/master/include/envoy/http/filter.h . Including the...