Ehsan Saei

Results 67 comments of Ehsan Saei

Hi @krishvoor thanks for reaching out to us. I was wondering if there is a native multi-arch support on TravisCI or they just use emulation?

one more [here](https://github.com/open-telemetry/opentelemetry-cpp/runs/7679175246?check_suite_focus=true#step:5:676): ``` WARNING: ThreadSanitizer: data race (pid=12) Write of size 8 at 0x7b4800000150 by main thread: #0 pthread_cond_destroy ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:1208 (libtsan.so.0+0x467aa) #1 opentelemetry::v1::exporter::otlp::OtlpHttpClient::~OtlpHttpClient() (libexporters_Sotlp_Slibotlp_Uhttp_Uclient.so+0x795ba) #2 std::default_delete::operator()(opentelemetry::v1::exporter::otlp::OtlpHttpClient*) const (otlp_http_exporter_test+0xf2977) #3...

> hi all - is there a status update on this issue? personally, I think just converting the API to a "regular" library would be easier - especially to attract...

Hi @owent, thanks for looking into this. I'd vote for not having a switch for supporting legacy.

Sure we will have breaking changes here. I'd still vote for not supporting legacy. We are already low on resources, and supporting both legacy and new proto will make maintenance...

old cmake compatible example can be found here: https://github.com/open-telemetry/opentelemetry-cpp/blob/521ebd8f51fb27219c8dd581629ec1b93df8b70a/sdk/test/trace/CMakeLists.txt#L1-L30

@lalitb sorry I was wrong, we have no example for the old Cmake version. I agree with @owent, I'd vote for upgrading the minimum required cmake.

`gcc 4.8` is already [broken](https://github.com/open-telemetry/opentelemetry-cpp/runs/7793318222?check_suite_focus=true) for the deprecated metrics. I removed it from #1531.

@meastp thanks for your work. I was wondering how [one_definition_rule](https://en.wikipedia.org/wiki/One_Definition_Rule) is preserved in your example: ```cpp #ifdef OTEL_WITH_HEADER_ONLY_API # include "opentelemetry/trace/noop.cc" #endif // OTEL_WITH_HEADER_ONLY_API // end of file ```

Hi @longwuyuan thanks for reaching out to us. Any reason for not installing `re2`? I could get the build working by installing `re2` and `re2-dev`. You may consider upgrading to...