Eric Seidel

Results 803 comments of Eric Seidel

It's not required. If you say that these changes make it work for you i can work to get them landed. Thanks.

OK, how about you do send me any spec you're willing to share that fails and I can make a non-AI patch that I do understand. :) Otherwise I'll work...

I'm not sure what package:core_icons is. I presume it's a private package. I believe Flutter knows how to tree-shake icon fonts based on usage. e.g. if you use CoreIcon.foo in...

https://github.com/flutter/flutter/blob/a3f61d250a5ca6e7249b0a14ffd2202f23926700/packages/flutter_tools/lib/src/build_system/targets/icon_tree_shaker.dart#L27 I believe it works on any icon font although I'm not sure how a package opts in/out.

One way to test would be to try building `shorebird release` and `shorebird patch` with --no-tree-shake-icons and see if the warning went away.

I think this would be reasonable to add to shorebird.yaml, some sort of "ignore_asset_changes:" or something for the code push config for cases like sentry (https://github.com/shorebirdtech/shorebird/issues/3079) or stripe (https://github.com/shorebirdtech/shorebird/issues/3048) assets...

Currently running `shorebird patch` with changed assets, will *warn* and then *ignore* the asset changes and only push the Dart changes to your users. https://docs.shorebird.dev/troubleshooting/#i-see-a-your-app-contains-asset-changes-warning-when-running-shorebird-patch

To close out, currently asset changes require a full update. When we solve https://github.com/shorebirdtech/shorebird/issues/318 that will go away. Thanks.

There are a lot of errors in that log. I'd start with the top: ``` 2025-03-24T10:04:47.251932 stderr: The current Dart SDK version is 3.6.0. Because americana requires SDK version ^3.7.0,...

Maybe WSL was used and caused this (e.g. running `shorebird` inside WSL vs. Powershell)?