Eric Seidel

Results 803 comments of Eric Seidel

https://letsencrypt.org/docs/caa/

Probably the record we'd want is: `shorebird.dev CAA 0 issue "letsencrypt.org"` letsencrypt.org is definitely the key name we want. "issue" is all we need ("issuewild" is for specifying separate controls...

Agreed. package:shorebird_code_push needs a docs/examples pass for sure. See also https://github.com/shorebirdtech/shorebird/issues/1140 and https://github.com/shorebirdtech/shorebird/issues/1981 which were confusion related to the api.

Another example: https://github.com/shorebirdtech/shorebird/issues/2434#issuecomment-2412688486

I think there is just a question of how much of fvm to support. I guess just reading the version number? https://github.com/shorebirdtech/shorebird/issues/1385

This confusion accounts for a measurable percentage of our support requests. My guess is 1/5th or more.

@tomarra if this blocks a customer its strightforward for us to add this to our api. (In fact it may already be there: https://github.com/shorebirdtech/shorebird/blob/main/packages/shorebird_code_push_protocol/lib/src/models/patch_artifact.dart). Let me know if you have...

Thanks! I'll look through it in more detail this weekend.

I think the changes here largely make sense, I just would need to write some test for them and/or have a motivating spec.

Yeah, I have a separate git repo (which I really should just post publicly) where I have several specs checked in that a test against. I haven't added date, email,...