escapedcat

Results 637 comments of escapedcat

Typecheck is failing :P

Should this now say "1 SAT"?: ![image](https://user-images.githubusercontent.com/1016218/197710592-6d14f9ff-01ec-4445-b1a8-c3d3bad42b6b.png)

> Yours is surely the old build as I removed "were" from the message Ugh, yes, thanks! Checked again. Looks great!

I think we should use the provided feature from i18next. But yes, we should make sure that `sat/s` is not being translated. I can have a look on how to...

![image](https://user-images.githubusercontent.com/1016218/194285575-d2e27176-5d12-416a-844b-6c30405d690f.png) Do we still want the success-screen when adding an account even after the onboarding? No, right? @dvoroneca @reneaaron

nit: button color on dark-mode looks off: ![image](https://user-images.githubusercontent.com/1016218/193998864-81071c6e-7309-4e3a-bd8d-28eee19ce5b4.png) Following your video, using this branch and Chromium I get: ![image](https://user-images.githubusercontent.com/1016218/193999723-c7acf7fa-5415-4751-83bc-75b1f0efce17.png) Do I need to user another browser? Copying & pasting the...

`db.js` was moved to TypeScript: https://github.com/getAlby/lightning-browser-extension/blob/master/src/extension/background-script/db.ts#L11

Can this be closed? We do this i.e. here, yes?: https://github.com/getAlby/lightning-browser-extension/blob/fix/currency-conversion-rate/src/extension/background-script/actions/ln/sendPayment.ts#L48

Before merging this to test it, some feedback. Looking at the changes it looks like our current "headlines"/"items" from our templates are not reflected in this. Would be nice to...