lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

add: bug/feature template forms

Open buneeIsSlo opened this issue 3 years ago • 8 comments

Describe the changes you have made in this PR

Added github bug/feature template forms.

Link this PR to an issue [optional]

Fixes #1547

Type of change

  • feat: New feature (non-breaking change which adds functionality)

How has this been tested?

I haven't tested this. I would love to know how to.

Checklist

  • [x] My code follows the style guidelines of this project and performed a self-review of my own code

buneeIsSlo avatar Oct 10 '22 12:10 buneeIsSlo

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

github-actions[bot] avatar Oct 10 '22 12:10 github-actions[bot]

Before merging this to test it, some feedback.

Looking at the changes it looks like our current "headlines"/"items" from our templates are not reflected in this. Would be nice to reflect the current structure. See:

  • https://github.com/getAlby/lightning-browser-extension/issues/new?assignees=&labels=%F0%9F%90%9E+bug&template=bug_report.md&title=
  • https://github.com/getAlby/lightning-browser-extension/issues/new?assignees=&labels=enhancement&template=feature_request.md&title=

You know what I mean?
Some points in the changes can be nice add-ons though, i.e. the "Did you check if a similar issue already exists" can be helpful.

I haven't tested this. I would love to know how to.

Creating a new test-repo in Github with these templates might work.

escapedcat avatar Oct 11 '22 06:10 escapedcat

Cool. I'll make the necessary changes and post screenshots in a bit.

buneeIsSlo avatar Oct 11 '22 07:10 buneeIsSlo

@escapedcat Below are the screenshots, let me know if you want me to change anything else.

Bug report

bugReport

Feature report

featureReport

buneeIsSlo avatar Oct 11 '22 11:10 buneeIsSlo

Thanks for this @buneeIsSlo !
I think we can leave out the [optional]-text now that we use the * to indicate required fields.
Apart form that this looks great.
@im-adithya @reneaaron @lisabaut what do you think?

escapedcat avatar Oct 12 '22 04:10 escapedcat

Ok, will fix that soon. You can test the forms here.

buneeIsSlo avatar Oct 12 '22 06:10 buneeIsSlo

Thanks for the testing link.

Looks good to me 👍

One tiny thing I would change:

"Screenshots of the changes[optional]" => "Screenshots [optional]"

Because the word "changes" is misleading in my opinion and the description below describes well what the screenshots should show.

lisabaut avatar Oct 12 '22 07:10 lisabaut

Made the final changes :)

buneeIsSlo avatar Oct 12 '22 08:10 buneeIsSlo

@escapedcat Hey, Is it cool if I go ahead and delete the test repo?

buneeIsSlo avatar Oct 21 '22 17:10 buneeIsSlo

@escapedcat Hey, Is it cool if I go ahead and delete the test repo?

Yes, thanks for you support!

escapedcat avatar Oct 22 '22 15:10 escapedcat

Thanks for the opportunity :)

buneeIsSlo avatar Oct 23 '22 03:10 buneeIsSlo